Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language additions and sorting filetypes #78

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

felixnorden
Copy link
Contributor

Wanted to add in some additional language comment types in here as I was lacking some of them myself in my flow using LazyVim! Please let me know if there's anything needed further to get this merged in!

This commit will:

  • Add in comment support for:
    • sh files
    • zsh files
    • solidity files
    • c files
  • Sort all languages in alphabetical order based on filetype/name
  • Rename the config table inside the config to languages as written in the TODO above

This commit will:
- Add in comment support for:
  - `sh` files
  - `zsh` files
  - `solidity` files
  - `c` files
- Sort all languages in alphabetical order based on filetype/name
Copy link
Owner

@JoosepAlviste JoosepAlviste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! I had some thoughts about the config key renaming, so that it wouldn't be a breaking change.

lua/ts_context_commentstring/config.lua Outdated Show resolved Hide resolved
@felixnorden
Copy link
Contributor Author

felixnorden commented Oct 6, 2023 via email

@felixnorden
Copy link
Contributor Author

@JoosepAlviste , I added in the changes but wasn't sure about how to mark the config field for deprecation properly. Apart from this, I think that the logic should be in order for merging languages and config based on the internal logic and allowing for overrides/extensions.

Let me know if you want me to put the merge from keep to force in the table merge, however, in case this needs to be done for end-user overrides/extensions to have priority over the supported languages out of the box!

Copy link
Owner

@JoosepAlviste JoosepAlviste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! I had a couple more thoughts on how to make this change less breaking for users 😅

doc/nvim-ts-context-commentstring.txt Outdated Show resolved Hide resolved
lua/ts_context_commentstring/config.lua Outdated Show resolved Hide resolved
lua/ts_context_commentstring/config.lua Outdated Show resolved Hide resolved
lua/ts_context_commentstring/config.lua Outdated Show resolved Hide resolved
@felixnorden
Copy link
Contributor Author

Roger that, will have a look on your comments and make sure we cover that as well! 👍 thanks for taking the time to go through it!

@JoosepAlviste JoosepAlviste merged commit 92e688f into JoosepAlviste:main Oct 12, 2023
1 check passed
@JoosepAlviste
Copy link
Owner

Looks great now, thanks for the contribution! And thanks for taking care of the config key renaming 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants