-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language additions and sorting filetypes #78
Conversation
This commit will: - Add in comment support for: - `sh` files - `zsh` files - `solidity` files - `c` files - Sort all languages in alphabetical order based on filetype/name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR! I had some thoughts about the config
key renaming, so that it wouldn't be a breaking change.
Sounds like a good plan, I’ll look to get those pieces covered tomorrow with a new commit to make sure we have a non-breaking change and update docs!
|
@JoosepAlviste , I added in the changes but wasn't sure about how to mark the Let me know if you want me to put the merge from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! I had a couple more thoughts on how to make this change less breaking for users 😅
Roger that, will have a look on your comments and make sure we cover that as well! 👍 thanks for taking the time to go through it! |
Looks great now, thanks for the contribution! And thanks for taking care of the config key renaming 😄 |
Wanted to add in some additional language comment types in here as I was lacking some of them myself in my flow using LazyVim! Please let me know if there's anything needed further to get this merged in!
This commit will:
sh
fileszsh
filessolidity
filesc
filesconfig
table inside theconfig
tolanguages
as written in the TODO above