feat(x): add h3/QUIC support to the fetch tool #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
commented
Nov 1, 2024
| @@ -1,20 +1,21 @@ | |||
| module github.com/Jigsaw-Code/outline-sdk/x | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
FYI, quic-go requires 1.22. We'll need to keep this quite recent in order to support newer protocol updates, unfortunately.
jyyi1
approved these changes
Nov 1, 2024
| } | ||
| } | ||
|
|
||
| _, err = io.Copy(os.Stdout, resp.Body) | ||
| fmt.Println() | ||
| if err != nil { | ||
| log.Fatalf("Read of page body failed: %v\n", err) | ||
| slog.Error("Read of page body failed", "error", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Note that os.Exit will bypass all defer calls, I guess it's OK in this PR since all resources will be cleaned up when the process ends.
There was a problem hiding this comment.
Good point. Though I'll also add that this is no different from what we currently have with the Fatal calls, which calls os.Exit.
Co-authored-by: J. Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: