ENH: Phone Input Component #189
Conversation
|
@JhumanJ Hey, were you able to take a look at this one yet? |
| }, | ||
| watch: { | ||
| inputVal(newVal, oldVal) { | ||
| this.compVal = this.selectedCountryCode.dial_code + newVal; |
There was a problem hiding this comment.
Please make sure to read all requirements
It should handle clashes for instance, for French number you don't need +33 and start with a 0, so if user selects +33 for France, and enters 0123456789, the resulting value should not be +330123456789 but +330123456789
There was a problem hiding this comment.
I'm not sure if I'm reading it right but do you mean that the result should be +33123456789 instead of +330123456789, with the extra 0 ignored?
There was a problem hiding this comment.
Have added the new logic to handle this scenario, please take a look
… 0 phone number is ignored, added regex to ignore non digit phone input
…170-phone-input-component
| </script> | ||
|
|
||
| <style scoped> | ||
| .dropdown { |
There was a problem hiding this comment.
Please stick to tailwind. We avoid css as much as possible, and usually don't use actual classes. Ex:
- Remove the class
dropdownand replace it withrelative w-1/4
There was a problem hiding this comment.
Done, using tailwind classes. Also, added a prop to the VSelect component as I wanted the opened dropdown options to have greater width than the selected option when dropdown closed. Do take a look at that
… prop for dropdown styling
…htritus/OpnForm into feat/170-phone-input-component
|
Currently this |
|
Great job, thank you @Ahtritus ! |
|
/claim #170 |
Hey @JhumanJ, made some more changes, do take a look now. Hope this is the expected behavior.
/claim #170