Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: #170 phone input structure #188

Closed

Conversation

Ahtritus
Copy link
Contributor

@Ahtritus Ahtritus commented Sep 4, 2023

ENH: #170 - Added phone input component with backend validation rules
image

@Ahtritus
Copy link
Contributor Author

Ahtritus commented Sep 4, 2023

@JhumanJ Hey, this seems to be working more or less as expected. However, the styling can still be improved a bit. Additionally, I'm not sure whether the rules added in the backend are enough and I haven't added any unit tests for them as well. Could you please guide me towards the next steps?

@Ahtritus Ahtritus changed the title Feat/170 phone input structure ENH: #170 phone input structure Sep 4, 2023
Copy link
Owner

@JhumanJ JhumanJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the great work. I've just gave it a try, but unfortunately this doesn't work for us, as the created input doesn't match the style of the inputs we already have (regardless of the theme). That's why I didn't recommend going with a library.

@Ahtritus
Copy link
Contributor Author

Ahtritus commented Sep 6, 2023

Hi, thanks for the great work. I've just gave it a try, but unfortunately this doesn't work for us, as the created input doesn't match the style of the inputs we already have (regardless of the theme). That's why I didn't recommend going with a library.

Hey, I made a couple of changes to make sure it works with all the themes but I'm guessing you're talking about the dropdown select element?

image

If that's the case, I'll perhaps give it some more time to create a custom input, only problem there is the flags which are a bit tricky.

@JhumanJ
Copy link
Owner

JhumanJ commented Sep 6, 2023

There's not only the dropdown, but also the colored shadow when input is focused and some other inconsistencies unfortunately. As mentioned, I think the flag issue can easily be resolved with a small library that does just this :)

@Ahtritus
Copy link
Contributor Author

Ahtritus commented Sep 6, 2023

Makes sense. I did go ahead and created a custom dropdown phone input component. Closing this and raising a new PR for that

@Ahtritus Ahtritus closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants