Validation logic bug, required with logic hidden

JhumanJ · Aug 7, 2023 · 398a548 · 398a548
1 parent 8f84faf
commit 398a548
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/Service/Forms/FormLogicPropertyResolver.php b/app/Service/Forms/FormLogicPropertyResolver.php
@@ -39,7 +39,7 @@ public function shouldBeRequired(): bool
         }
 
         $conditionsMet = FormLogicConditionChecker::conditionsMet($this->logic['conditions'], $this->formData);
-        if ($conditionsMet && $this->property['required'] && count($this->logic['actions']) > 0 && in_array('make-it-optional', $this->logic['actions'])) {
+        if ($conditionsMet && $this->property['required'] && count($this->logic['actions']) > 0 && (in_array('make-it-optional', $this->logic['actions']) || in_array('hide-block', $this->logic['actions']))) {
             return false;
         } else if ($conditionsMet && !$this->property['required'] && count($this->logic['actions']) > 0 && in_array('require-answer', $this->logic['actions'])) {
             return true;