Line numbers: Improve performance #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgronover
requested changes
Dec 18, 2023
…te_events_2021_3' into bugfix/throttle_line_number_update_events_2021_3
alexanderpann
deleted the
bugfix/throttle_line_number_update_events_2021_3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #726
The left highlighter gets way too many relayout events which we can't influence, so we have to throttle the number of events. I've selected 250ms, which means that the line numbers only update 4 times per second or less. I've tried to create many new lines in the mbeddr documentation for testing and the update interval seems to be sufficient for small and large editors.