Add a new flag to pull attribute editors into edge labels #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality is hidden behind the new "pull annotations" property of diagram editors. Only if the flag is true (default false) will the behavior change.
Removes print statements
This makes it easier to customize the behavior of the flag
alexanderpann
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a model node had an attribute annotation and is used as an edge in a diagram, the attribute editor would be added as an external box in the diagram (also see example node
R1in the repo):In this picture, the annotation
Component Annotationis floating around in the diagram. Auto-layouting also does not work.This PR adds support for pulling these annotations into the edge labels:
The key difference is that in the new setting, the annotation is part of the edge label and thus also automatically layouted.
To apply this change, the PR adds a new flag
pullAnnotationsas a boolean query over the node and the editor context. The standard behavior from above is retained by leaving it at the defaultfalsevalue.This work was done jointly with @slisson.