Added option to sort books in library by oldest unread chapter (next unread chapter). #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, it's been some time. Is the project open for outside contributions like this? Is there something I can/should do to get this reviewed? I'm open for any questions. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes feature request #1443, posted by me a few days ago. This aims to make it easier for users to read chapters across multiple series in release order.
This involves a few additional functions for the SQL queries and the new option in the UI.
Tests
I tested that the ascending/descending order matches the already existing "last updated" order, in the case where those are the same (when the only unread chapter is the latest chapter). For titles with no unread chapters, the behavior is to default to alphabetical, like other similar sorting options.
Possible alternative
This implementation interprets "next" as "oldest unread chapter". If a user skipped chapters, that's not quite the case. However, this interpretation matches the current behavior for clicking the open book button in the library (opens to the oldest unread chapter).
An alternative approach would be to find the actual latest chapter read in the user history, then find the next chapter from there.