Fix z.warning behaviour and messages #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dear @Japal Thank you for developing zCompositions package and sharing its source code. I seem to have found a couple of issues after the last commit. Mainly, the code for detecting zeros in rows was using columns and I also changed the error message for a warning when z.delete is set to FALSE, as otherwise the function stops without computing the results. I added some extra spaces for a longer format, but that is just aesthethic. I hope you find these proposed changes useful.
|
Done! Many thanks @lmartinezgili |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @Japal
Thank you for developing zCompositions package and sharing its source code.
I seem to have found a couple of issues after the last commit. Mainly, the code for detecting zeros in rows was using columns and I also changed the error message for a warning when z.delete is set to FALSE, as otherwise the function stops without computing the results.
I added some extra spaces for a longer format, but that is just aesthethic.
I hope you find these proposed changes useful.