Skip to content

Commit

Permalink
Remove a buggy and unnecessary dialog box
Browse files Browse the repository at this point in the history
This dialog box freezes the entire program on some systems
due to the way they tie the dialog box to the password
entry window. A freeze on first run isn't a good first
impression
  • Loading branch information
JFreegman committed Jan 31, 2024
1 parent 24dbe11 commit b122262
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/gui.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1178,13 +1178,6 @@ static void on_newPwButtonEnter_clicked(GtkEntry *button, gpointer data)

char msg[1024];

snprintf(msg, sizeof(msg), "Profile successfully created.\n\n"\
"Please remember that the store file is encrypted on your disk, "\
"and that it is impossible to recover your data if you lose "\
"or forget your master password.\n\n"\
"It is strongly recommended that you regularly create backups of the store file, "\
"located at: %s", path.c_str());

if (text1_len < MIN_MASTER_PASSWORD_SIZE) {
snprintf(msg, sizeof(msg), "Password must be at least %d characters long", MIN_MASTER_PASSWORD_SIZE);
goto on_exit;
Expand Down Expand Up @@ -1216,7 +1209,6 @@ static void on_newPwButtonEnter_clicked(GtkEntry *button, gpointer data)
on_exit:

if (!has_err) {
dialog_box(cb_data->app, msg, GTK_MESSAGE_INFO, window);
gtk_widget_destroy(window);
crypto_memwipe(passBuff, sizeof(passBuff));
free(cb_data);
Expand Down

0 comments on commit b122262

Please sign in to comment.