Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openmpi version on Hercules #1326

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Oct 5, 2024

Summary

Switched from used installed openmpi 4.1.6-gcc-12.2.0-spack to system installed [email protected]
This fixed problem on installing gcc environment on Hercules.

Testing

Installed spack-stack-1.8.0/gcc
Wiki page updated,

Systems affected

Hercules

Issue(s) addressed

#1278

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

That's fantastic! I guess it warrants re-tagging once more, but I am going to wait until we (hopefully) have a PR merged for S4, too.

Can you confirm that Orion is also good now? I see you updated the Wiki page for that system.

@RatkoVasic-NOAA
Copy link
Collaborator Author

Can you confirm that Orion is also good now? I see you updated the Wiki page for that system.

Confirming, both Hercules and Orion have both Intel and GNU environments installed.

@climbfuji climbfuji merged commit 46234a7 into JCSDA:release/1.8.0 Oct 7, 2024
8 checks passed
@RatkoVasic-NOAA
Copy link
Collaborator Author

RatkoVasic-NOAA commented Oct 7, 2024

@climbfuji
In the meantime I tried to run ufs-weather-model on Hercules using 1.8.0 (both Intel and GNU). It did compile, but when linking, it complained that curl is having problem with openssl. I made changes in packages.yaml to use system installed curl, openssh and openssl, and model is running now OK. ==add - it passed all 5 chosen regression tests ==

Changes:

<     curl:
<       externals:
<       - spec: [email protected]+gssapi+ldap+nghttp2
<         prefix: /usr
100,107d62
<     openssh:
<       externals:
<       - spec: [email protected]
<         prefix: /usr
<     openssl:
<       externals:
<       - spec: [email protected]
<         prefix: /usr

While typing this, I saw you committed this PR. I'll do another one. Or, maybe I can try to run ufs-weather-model other machines and collect changes (if any other that Hercules) into one PR.

@climbfuji
Copy link
Collaborator

hmm ok - yes please, try the other platforms if you can

@RatkoVasic-NOAA
Copy link
Collaborator Author

@climbfuji here we stand with ufs-weather-model:

  1. Hera, Gaea-C5, and Hercules (with curl/openssl changes) works OK.
  2. Orion is missing zlib-ng (old issue Problems of zlib-ng with [email protected] on some - not all - systems #1055). I'm installing zlib-ng right now, but it takes time, lots of dependencies. Hopefully this will work.
  3. ufs-weather-model-env is missing SP library everywhere. Only Derecho is using it, so it failed. When I load manually sp lib, Derecho compiled OK.
  4. Jet - failed in cmake, I'll take a look into this next.

Can you please check why is 1.8.0 skipping sp library for ufs-weather-model-env/1.0.0.lua? BTW, it is missing in 1.7.0 as well, 1.6.0 is OK.

@climbfuji
Copy link
Collaborator

Regarding sp, this is expected and the solution is to manually load it if needed. This is not an error.

See also #1330

@RatkoVasic-NOAA
Copy link
Collaborator Author

OK, we can add it in ufs-weather-model derecho module file.

@climbfuji
Copy link
Collaborator

I don't understand why that is needed. All UFS platforms currently load the individual modules explicitly, including sp.

https://github.com/ufs-community/ufs-weather-model/blob/develop/modulefiles/ufs_common.lua

@RatkoVasic-NOAA
Copy link
Collaborator Author

Not all, Derecho is (for reason unknown to me) using:

setenv("CMAKE_Platform", "derecho.intel")
load("ufs-weather-model-env")

in ufs_derecho.intel.lua

@climbfuji
Copy link
Collaborator

Not all, Derecho is (for reason unknown to me) using:

setenv("CMAKE_Platform", "derecho.intel")
load("ufs-weather-model-env")

in ufs_derecho.intel.lua

Now I remember ... but I don't remember why we had to do this. Ok, makes sense then.

climbfuji pushed a commit to climbfuji/spack-stack that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants