Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a script that checks languages #70

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

categulario
Copy link
Contributor

This can help with #63. Maybe if added to a CI pipeline like travisCI or github actions, combined with a badge in the readme it won't be necessary to have this issue open.

I ran the script and it reported that french is not valid json btw

Copy link
Owner

@J-Rios J-Rios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution :)

The script is useful, however the issue also point to existing keys that could have a translated text from a previous version, so it should keep open as a notice to every one.

Best Regards.

@J-Rios J-Rios merged commit 9211b9c into J-Rios:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants