Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize initialization of local SmartPointer variables in Examples #4971

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Modernize initialization of local SmartPointer variables in Examples #4971

merged 2 commits into from
Nov 21, 2024

Conversation

N-Dekker
Copy link
Contributor

Triggered by a comment by Bradley Lowekamp (@blowekamp) at #4964 (comment)

@N-Dekker
STYLE: Replace Pointer var; var = x with Pointer var = x in Examples
e6bc01e 
- Follow-up to pull request InsightSoftwareConsortium#4964
commit 4926511
"STYLE: Replace `Pointer var; var = x` with `Pointer var = x`"

Triggered by a comment by Bradley Lowekamp at
InsightSoftwareConsortium#4964 (comment)
@N-Dekker
STYLE: Replace T::Pointer with auto when initializing by New in Examples
b03776a 
- Follow-up to pull request InsightSoftwareConsortium#4964
commit 677b761
"STYLE: Replace T::Pointer with auto when initializing variables by New()"

Triggered by a comment by Bradley Lowekamp at
InsightSoftwareConsortium#4964 (comment)
@github-actions github-actions bot added the area:Examples Demonstration of the use of classes label Nov 21, 2024
@N-Dekker N-Dekker marked this pull request as ready for review November 21, 2024 10:43
blowekamp
blowekamp reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Need to keep examples upto date with modern C++ too.

@hjmjohnson hjmjohnson merged commit 26b0378 into InsightSoftwareConsortium:master Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowekamp blowekamp blowekamp left review comments

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Examples Demonstration of the use of classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N-Dekker @hjmjohnson @blowekamp