Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BUG: Reduce tolerance for same slice checks" #4967

Conversation

hjmjohnson
Copy link
Member

This reverts commit 916a40c.

The strict tolerance is required for backward compatibility.

The commit 916a40c caused an undesirable regression in end-user application, and was not necessary for fixing the problem described in #4955

PR Checklist

This reverts commit 916a40c.

The strict tolerance is required for backward compatibility.
@hjmjohnson hjmjohnson added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Nov 20, 2024
@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Nov 20, 2024
@hjmjohnson hjmjohnson self-assigned this Nov 20, 2024
@github-actions github-actions bot added area:IO Issues affecting the IO module and removed type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances labels Nov 20, 2024
@hjmjohnson
Copy link
Member Author

@seanm Sorry for my mistake. The code you identified is problematic and should not have been committed.

@seanm
Copy link
Contributor

seanm commented Nov 21, 2024

@seanm Sorry for my mistake. The code you identified is problematic and should not have been committed.

No worries, thanks for the quick fix!

@thewtex thewtex merged commit ac021d0 into InsightSoftwareConsortium:master Nov 21, 2024
17 checks passed
@seanm
Copy link
Contributor

seanm commented Nov 22, 2024

I was thinking to modify a unit test to check ITK_non_uniform_sampling_deviation but I'm having a hard time finding a test that reads multiple dicom files. Many seem to read only a single file/slice. The test files also have weird file names, and symlinks, and it's all hard to untangle...

Anyone know of any?

@blowekamp
Copy link
Member

I was thinking to modify a unit test to check ITK_non_uniform_sampling_deviation but I'm having a hard time finding a test that reads multiple dicom files. Many seem to read only a single file/slice. The test files also have weird file names, and symlinks, and it's all hard to untangle...

Anyone know of any?

I though we use to have more comprehensive data in the Examples, but I think that may have been with the old registration examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:IO Issues affecting the IO module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants