-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Let PointSet::Clone()
do a "deep copy", instead of no copy at all
#4925
ENH: Let PointSet::Clone()
do a "deep copy", instead of no copy at all
#4925
Conversation
Implemented InternalClone() for PointSet and PointSetBase, in order to let `PointSet::Clone()` and `PointSetBase::Clone()` do a deep copy of its points and point data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any existing uses of PointSet::Clone()
?
- Addressed a comment by Matt McCormick at InsightSoftwareConsortium#4923 (comment)
Thanks for your approval @dzenanz 👍 And regarding your comment at #4923 (comment)
Indeed, we excluded any '*.md' file and anything in the Documentation directory: ITK/Testing/ContinuousIntegration/AzurePipelinesLinux.yml Lines 9 to 26 in 5b121f4
In vain, apparently 🤷 |
Implemented InternalClone() for PointSet and PointSetBase, in order to let
PointSet::Clone()
andPointSetBase::Clone()
do a deep copy of its points and point data.Following the suggestion from Bradley (@blowekamp) to override InternalClone(), at ENH: Add Clone() and MakeDeepCopy() to PointSetBase #4923 (comment)
Intended to supersede pull request ENH: Add Clone() and MakeDeepCopy() to PointSetBase #4923