Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Let PointSet::Clone() do a "deep copy", instead of no copy at all #4925

Merged

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Nov 1, 2024

Implemented InternalClone() for PointSet and PointSetBase, in order to let PointSet::Clone() and PointSetBase::Clone() do a deep copy of its points and point data.


Implemented InternalClone() for PointSet and PointSetBase, in order to let
`PointSet::Clone()` and `PointSetBase::Clone()` do a deep copy of its points and
point data.
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module labels Nov 1, 2024
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any existing uses of PointSet::Clone()?

@N-Dekker N-Dekker marked this pull request as ready for review November 1, 2024 16:09
@github-actions github-actions bot added the area:Documentation Issues affecting the Documentation module label Nov 6, 2024
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Nov 6, 2024

Thanks for your approval @dzenanz 👍 And regarding your comment at #4923 (comment)

I remember that we exclude some non-code changes from triggering the CI.

Indeed, we excluded any '*.md' file and anything in the Documentation directory:

exclude:
- '*.md'
- LICENSE
- NOTICE
- Documentation/*
- Utilities/Debugger/*
- Utilities/ITKv5Preparation/*
- Utilities/Maintenance/*
pr:
paths:
exclude:
- '*.md'
- LICENSE
- NOTICE
- Documentation/*
- Utilities/Debugger/*
- Utilities/ITKv5Preparation/*
- Utilities/Maintenance/*

In vain, apparently 🤷

@dzenanz dzenanz merged commit 148bc32 into InsightSoftwareConsortium:master Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants