Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Improve itk::RGBGibbsPriorFilter documentation #4200

Conversation

jhlegarreta
Copy link
Member

  • DOC: Use Doxygen math syntax for math notation in class documentation
  • DOC: Document RGBGibbsPriorFilter class methods in header file only
  • DOC: Use proper Doxygen documentation style in RGBGibbsPriorFilter
  • STYLE: Prefer double forward slashes for within-method body comments

PR Checklist

@github-actions github-actions bot added type:Documentation Documentation improvement or change area:Segmentation Issues affecting the Segmentation module labels Sep 4, 2023
@jhlegarreta jhlegarreta force-pushed the ImproveRGBGibbsPriorFilterDocumentation branch 2 times, most recently from f3a965d to 32cf87c Compare September 4, 2023 16:36
Use Doxygen math syntax for math notation in `itk::RGBGibbsPriorFilter`.
Document `itk::RGBGibbsPriorFilter` class methods in header file only:
Doxygen picks the method documentation from the header files, and leaves
the method documentation empty if it does not find it there. So remove
the method documentation from the implementation file.

Take advantage of the commit to use the Doxygen math syntax where math
symbols are used in the doumented methods.
Use proper Doxygen documentation style in `itk::RGBGibbsPriorFilter`:
place the variables and type alias documentation blocks on the immediate
preceding line.

Take advantage of the commit to:
- Reword the documentation where appropriate: especially, remove
  unnecessary articles that refer to the ivar being documented.
- Use the Doxygen math syntax to highlight math symbols.
Prefer double forward slashes for within-method body comment blocks
following the ITK SWG coding style guidelines.

Reword the comments as appropriate to improve grammar.

Follow-up to commit be6b447.
@jhlegarreta jhlegarreta force-pushed the ImproveRGBGibbsPriorFilterDocumentation branch from 32cf87c to 8d3df52 Compare September 7, 2023 00:40
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 📖 awesome!

@thewtex thewtex merged commit 4b6ff31 into InsightSoftwareConsortium:master Sep 7, 2023
5 checks passed
@jhlegarreta jhlegarreta deleted the ImproveRGBGibbsPriorFilterDocumentation branch September 7, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Segmentation Issues affecting the Segmentation module type:Documentation Documentation improvement or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants