STYLE: Use macros in itk::SLICImageFilter test
#4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Enhancement
Prefer using macros to exercise `itk::SLICImageFilter` basic methods: - Exercise basic object methods using the `ITK_EXERCISE_BASIC_OBJECT_METHODS`. Remove redundant calls to test the filter class and superclass names and to print the filter: rely on the basic method exercising macro call. - Refactor the helper method to return a value as the macro may return a value, and rename it to honor its purpose. - Rename the google test method to honor its contents.
Use standard exit return code in `itk::SLICImagetFilter` test.
Conform to ITK SWG style guidelines in test ending message in `itk::SLICImageFilter` test: add a message to mark the test end to match the recommended test ending message.
jhlegarreta
force-pushed
the
IncreaseSLICImageFilterCoverage
branch
from
7ab0f35
to
d9f0d5e
Compare
jhlegarreta
changed the title
itk::SLICImageFilter coverageitk::SLICImageFilter test
dzenanz
approved these changes
Sep 4, 2023
blowekamp
reviewed
Sep 5, 2023
| @@ -140,5 +148,6 @@ itkSLICImageFilterTest(int argc, char * argv[]) | |||
| } | |||
|
|
|||
|
|
|||
| return 0; | |||
| std::cout << "Test finished." << std::endl; | |||
There was a problem hiding this comment.
I don't think this print statement above is useful
There was a problem hiding this comment.
This was brought in PR #3724 and maybe several other PRs as well; memory was failing me but Dženan made it clear what I believe is one of the benefits of this. Eventually, using a macro that involves the message and the return code (cross-referencing issue #1273) could be beneficial, and bring the debate down to a single line across the whole codebase.
There was a problem hiding this comment.
Just add it here if it is important:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/TestKernel/include/itkTestDriverAfterTest.inc#L23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itk::SLICImageFilterbasic methodsitk::SLICImagetFiltertestPR Checklist