Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Use standard return codes in example #4185

Merged
merged 2 commits into from
Sep 5, 2023
Merged

STYLE: Use standard return codes in example #4185

merged 2 commits into from
Sep 5, 2023

Conversation

jhlegarreta
Copy link
Member

  • STYLE: Use standard return codes in example
  • STYLE: Increase consistency in example argument check message

PR Checklist

@jhlegarreta
STYLE: Use standard return codes in example
2535192 
Use standard return codes in example.
@jhlegarreta
STYLE: Increase consistency in example argument check message
5707df8 
Increase consistency in example missing argument check message,
following the ITK SW guide coding guidelines. Specifically:
- Make the error message be consistent.
- Make the layout of the statements be consistent.
- Remove excessive whitespaces.
@github-actions github-actions bot added area:Examples Demonstration of the use of classes type:Style Style changes: no logic impact (indentation, comments, naming) labels Sep 2, 2023
thewtex
thewtex approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thewtex thewtex merged commit f9b153a into InsightSoftwareConsortium:master Sep 5, 2023
5 checks passed
@jhlegarreta jhlegarreta deleted the UseStandardReturnCodesInExample branch September 5, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:Examples Demonstration of the use of classes type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @thewtex @dzenanz