Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lock_guard<mutex> in itkPlatformMultiThreaderWindows, ParallelSparseFieldLevelSetImageFilter, and PDEDeformable Registration #4180

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Use lock_guard<mutex> in itkPlatformMultiThreaderWindows, ParallelSparseFieldLevelSetImageFilter, and PDEDeformable Registration #4180

merged 3 commits into from
Sep 1, 2023

Commits on Aug 31, 2023

  1. STYLE: Use lock_guard<mutex> in PlatformMultiThreader::TerminateThread 

    Follow-up to pull request InsightSoftwareConsortium#4173
commit c4c3710
"STYLE: Use `lock_guard<mutex>` in `PlatformMultiThreader` classes"
    @N-Dekker
    N-Dekker committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2e2ad85 View commit details
    Browse the repository at this point in the history

  2. STYLE: Use lock_guard<mutex> in ParallelSparseFieldLevelSetImageFilter 

    Following C++ Core Guidelines, April 13, 2023, "Use RAII, never plain `lock()`/`unlock()`"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cp20-use-raii-never-plain-lockunlock
    @N-Dekker
    N-Dekker committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    ae3f808 View commit details
    Browse the repository at this point in the history

  3. STYLE: Use lock_guard<mutex> in PDEDeformable Registration classes 

    Following C++ Core Guidelines, April 13, 2023, "Use RAII, never plain `lock()`/`unlock()`"
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cp20-use-raii-never-plain-lockunlock

Also replaced raw `GlobalDataStruct` pointers by `std::unique_ptr` and removed
manual `delete globalData` statements from `ReleaseGlobalDataPointer` member
functions.
    @N-Dekker
    N-Dekker committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    46e3a19 View commit details
    Browse the repository at this point in the history