STYLE: Improve miscellaneous tests' style #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Testing
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
from
502d776
to
b8f69dc
Compare
jhlegarreta
commented
Aug 31, 2023
|
|
||
|
|
||
| expander->ResetPipeline(); | ||
| expander->SetInterpolator(interpolator); |
There was a problem hiding this comment.
It is weird that I had to add these two lines after the call to update the filter. The previous commit 10b5e6a produced a test failure:
https://open.cdash.org/viewTest.php?onlyfailed&buildid=8953052
It is unclear to me the reason of such failure, despite the test completing its instructions. Even more so this being a seemingly harmless style change. Any thoughts?
issakomi
reviewed
Aug 31, 2023
Modules/Filtering/ImageIntensity/test/itkVectorExpandImageFilterTest.cxx
Show resolved
Hide resolved
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
from
b8f69dc
to
3a21783
Compare
Declare variables close to where they are used in tests and initialize them at declaration.
Declare and use image dimensionality as a constant expression in miscellaneous tests instead of hard-coding the value across different statements.
Do not declare a test status variable that is only used once: prefer using directly the appropriate return value.
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
2 times, most recently
from
751bca2
to
e14a731
Compare
issakomi
reviewed
Sep 1, 2023
issakomi
approved these changes
Sep 1, 2023
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
from
e14a731
to
4a1495a
Compare
github-actions
bot
added
area:Registration
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
5 times, most recently
from
d2c797a
to
c179ce3
Compare
github-actions
bot
removed
area:Registration
Allow `itkCellInterfaceTest` to run as long as possible: store the check status value in a variable and return such value at the end of the test. Conform to the ITK SWG guidelines by doing so.
Use exception checking macros in `itkVectorExpandImageFilterTest.cxx`: - Use the `ITK_TRY_EXPECT_EXCEPTION` macro to check expected exceptions when updating filters in lieu of `try/catch` blocks for the sake of readability and compactness, and to save typing/avoid boilerplate code. - Only place the code that might raise exceptions within the macro. - Change the test status variable type to accomodate for the changes above.
Prefer setting the input once all ivars have been set in `itkPatchBasedDenoisingImageFilterDefaultTest.cxx`.
jhlegarreta
force-pushed
the
ImproveMiscTestsStyle
branch
from
c179ce3
to
bdab6cf
Compare
dzenanz
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constexpritkCellInterfaceTestto run as long as possiblePR Checklist