ENH: Increase coverage for miscellaneous classes #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Enhancement
jhlegarreta
force-pushed
the
IncreaseMiscClassesCoverage19
branch
2 times, most recently
from
7a7208b
to
af8701f
Compare
|
seem to be ok |
vfonov
approved these changes
Aug 23, 2023
Increase coverage for miscellaneous classes: - Exercise basic object methods using the `ITK_EXERCISE_BASIC_OBJECT_METHODS` macro. - Test the boolean ivars using the `ITK_TEST_SET_GET_BOOLEAN` macro. - Use other testing macros as necessary to check for expected values. - Test the exceptions using the `ITK_TRY_EXPECT_EXCEPTION`. - Explicitly call the `Print` method when some ivars (e.g. containers of some kind) need to have some data so that the corresponding serialization statements in the `PrintSelf` method can be called. Call these methods once the instance data has been set and the filter has been updated.
jhlegarreta
force-pushed
the
IncreaseMiscClassesCoverage19
branch
from
af8701f
to
f710802
Compare
|
Note that tests may pass even if compilation errors occur or checks do not pass in |
jhlegarreta
commented
Aug 27, 2023
| using TransformAdapterTypeExcp44 = | ||
| itk::MINCTransformAdapter<ParametersValueType, InputDimensionExcp4, OutputDimensionExcp4>; | ||
|
|
||
| ITK_TRY_EXPECT_EXCEPTION(TransformAdapterTypeExcp44::New()); |
There was a problem hiding this comment.
The above three cases should ideally be done with a Cartesian product, but the template requires compile time constants. Maybe future versions of C++ will allow doing a constexpr auto prod = CartesianProduct() (?)
|
Compiles fine locally (Win 10; MSVC 2022); the test is segfaulting for other reasons: cross-referencing #4175 (comment) All new checks added in this patch set pass for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase coverage for miscellaneous classes:
ITK_EXERCISE_BASIC_OBJECT_METHODSmacro.ITK_TEST_SET_GET_BOOLEANmacro.ITK_TRY_EXPECT_EXCEPTION.Printmethod when some ivars (e.g. containers of some kind) need to have some data so that the corresponding serialization statements in thePrintSelfmethod can be called. Call these methods once the instance data has been set and the filter has been updated.PR Checklist