COMP: Remove pkg_resources import from base.py #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address: ``` ../../../../../../bin/micromamba/envs/itk-wasm/lib/python3.11/site-packages/itk/support/base.py:26 pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html ../../../../../../bin/micromamba/envs/itk-wasm/lib/python3.11/site-packages/pkg_resources/__init__.py:2871 Deprecated call to `pkg_resources.declare_namespace('mpl_toolkits')`. Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages ``` This was brought it by InsightSoftwareConsortium@b7b6638 to work around an xarray import issue, but with xarray-2023.8.0, the tests pass.
github-actions
bot
added
type:Compiler
jhlegarreta
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
pkg_resources is also deprecated in favor of importlib.resources, importlib.metadata. See the warning below:
https://setuptools.pypa.io/en/latest/pkg_resources.html#package-discovery-and-resource-access-using-pkg-resources
Thanks Matt.
tbirdso
approved these changes
Aug 21, 2023
dzenanz
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address:
This was brought it by b7b6638 to work around an xarray import issue, but with xarray-2023.8.0, the tests pass.