Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Increase coverage for miscellaneous classes #4148

Merged
merged 1 commit into from
Aug 8, 2023
Merged

ENH: Increase coverage for miscellaneous classes #4148

merged 1 commit into from
Aug 8, 2023

Conversation

jhlegarreta
Copy link
Member

Increase coverage for miscellaneous classes:

  • Exercise basic object methods using the ITK_EXERCISE_BASIC_OBJECT_METHODS macro. Remove redundant calls to print the filter: rely on the basic method exercising macro call.
  • Test the Set/Get methods using the ITK_TEST_SET_GET_VALUE macro.
  • Test the boolean ivars using the ITK_TEST_SET_GET_BOOLEAN macro.
  • Call other Get methods for ivars that have no Set methods/ivars having an informative purpose.
  • Remove statements that serialize the values obtained through the Get macro and call the Get methods in the context of the quantitative testing macros.

PR Checklist

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module type:Coverage Code coverage impacts labels Aug 8, 2023
@jhlegarreta
ENH: Increase coverage for miscellaneous classes
99abf7b 
Increase coverage for miscellaneous classes:
- Exercise basic object methods using the
  `ITK_EXERCISE_BASIC_OBJECT_METHODS` macro. Remove redundant calls to
  print the filter: rely on the basic method exercising macro call.
- Test the Set/Get methods using the `ITK_TEST_SET_GET_VALUE` macro.
- Test the boolean ivars using the `ITK_TEST_SET_GET_BOOLEAN` macro.
- Call other Get methods for ivars that have no Set methods/ivars having
  an informative purpose.
- Remove statements that serialize the values obtained through the Get
  macro and call the Get methods in the context of the quantitative
  testing macros.
@jhlegarreta jhlegarreta force-pushed the IncreaseMiscClassesCoverage17 branch from 8dd3730 to 99abf7b Compare August 8, 2023 02:29
@github-actions github-actions bot added the area:Numerics Issues affecting the Numerics module label Aug 8, 2023
thewtex
thewtex approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta thank you!!

dzenanz
dzenanz approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@jhlegarreta jhlegarreta merged commit 85dd887 into InsightSoftwareConsortium:master Aug 8, 2023
5 checks passed
@jhlegarreta jhlegarreta deleted the IncreaseMiscClassesCoverage17 branch August 8, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Coverage Code coverage impacts type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @thewtex @dzenanz