Support multi-component images in image_from_vtk_image function #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
added a commit
to dzenanz/Slicer
that referenced
this pull request
Aug 8, 2023
This is heavily dependent on a fix in ITK: InsightSoftwareConsortium/ITK#4142
dzenanz
added a commit
to KitwareMedical/SlicerITKUltrasound
that referenced
this pull request
Aug 8, 2023
jcfr
pushed a commit
to dzenanz/Slicer
that referenced
this pull request
Aug 8, 2023
This is heavily dependent on a fix in ITK: InsightSoftwareConsortium/ITK#4142
dzenanz
force-pushed
the
multiComponentVTK
branch
from
e022431
to
77d4478
Compare
github-actions
bot
added
the
type:Testing
dzenanz
added a commit
to KitwareMedical/SlicerITKUltrasound
that referenced
this pull request
Aug 8, 2023
…rray Bump itk-ultrasound version number to include InsightSoftwareConsortium/ITK#4142
thewtex
approved these changes
Aug 9, 2023
jcfr
reviewed
Aug 10, 2023
3 tasks
jcfr
reviewed
Aug 10, 2023
| dims = dims[:-1] # 2D, not 3D | ||
| dims.reverse() | ||
| if is_vector: | ||
| dims.append(number_of_components) |
There was a problem hiding this comment.
Suggested change
| dims.append(number_of_components) | |
| dims.append(number_of_components) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this while working on Slicer/Slicer#7094.
PR Checklist