STYLE: Replace T var; var = x with T var = x for scalars in tests

Following C++ Core Guidelines, Oct 3, 2024, "Always initialize an object",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always

Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+)([a-z][a-z ]*[a-z])([ ]+)(\w+);[\r\n]+\1\4\ =
    Replace with: $1$2$3$4 =
    Filters: itk*Test*.*
    [v] Match case
    (*) Regular expression

Modules/Core/Common/test/itkIteratorTests.cxx

@@ -124,8 +124,7 @@ itkIteratorTests(int, char *[])
   start = clock();
   itk::ImageRegionIterator<ScalarImage> it(o3, region);
 
-  unsigned short scalar;
-  scalar = 5;
+  unsigned short scalar = 5;
 
   i = 0;
   for (; !it.IsAtEnd(); ++it)

Modules/Core/ImageAdaptors/test/itkVectorImageTest.cxx

@@ -442,9 +442,9 @@ itkVectorImageTest(int, char * argv[])
         std::cerr << "[FAILED]" << std::endl;
         failed = true;
       }
-      bool adaptorTestResult;
-      adaptorTestResult = testVectorImageAdaptor<PixelType, Dimension, VectorImageToImageAdaptorType, VectorLength>(
-        vectorImageToImageAdaptor, vectorImage, region, componentToExtract);
+      bool adaptorTestResult =
+        testVectorImageAdaptor<PixelType, Dimension, VectorImageToImageAdaptorType, VectorLength>(
+          vectorImageToImageAdaptor, vectorImage, region, componentToExtract);
       if (adaptorTestResult)
       {
         failed = true;

Modules/Core/Transform/test/itkBSplineDeformableTransformTest.cxx

@@ -687,9 +687,7 @@ itkBSplineDeformableTransformTest3()
 int
 itkBSplineDeformableTransformTest(int, char *[])
 {
-  bool failed;
-
-  failed = itkBSplineDeformableTransformTest1();
+  bool failed = itkBSplineDeformableTransformTest1();
   if (failed)
   {
     return EXIT_FAILURE;

Modules/Core/Transform/test/itkBSplineTransformTest.cxx

@@ -715,9 +715,7 @@ itkBSplineTransformTest3()
 int
 itkBSplineTransformTest(int, char *[])
 {
-  bool failed;
-
-  failed = itkBSplineTransformTest1();
+  bool failed = itkBSplineTransformTest1();
   if (failed)
   {
     return EXIT_FAILURE;

Modules/Core/Transform/test/itkTestTransformGetInverse.cxx

@@ -106,8 +106,7 @@ TransformTest()
 int
 itkTestTransformGetInverse(int, char *[])
 {
-  unsigned int errorCount;
-  errorCount = TransformTest<itk::AffineTransform<double, 3>>();
+  unsigned int errorCount = TransformTest<itk::AffineTransform<double, 3>>();
   errorCount += TransformTest<itk::AzimuthElevationToCartesianTransform<double, 3>>();
   errorCount += TransformTest<itk::BSplineTransform<double, 3>>();
   errorCount += TransformTest<itk::CenteredAffineTransform<double, 3>>();

Modules/Filtering/AntiAlias/test/itkAntiAliasBinaryImageFilterTest.cxx

@@ -40,13 +40,12 @@ constexpr int V_DEPTH = 64;
 float
 sphere(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }
 

Modules/Filtering/ImageGrid/test/itkInterpolateImagePointsFilterTest.cxx

@@ -255,8 +255,7 @@ test3DInterpolateImagePointsFilter()
   using OutputIterator = itk::ImageRegionIterator<CoordImageType3D>;
   InputIterator  inIter(image, region);
   OutputIterator outIter(outputImage, region);
-  double         rmse;
-  rmse = 0.0;
+  double         rmse = 0.0;
   while (!outIter.IsAtEnd())
   {
     double temp = inIter.Get() - outIter.Get();

Modules/Filtering/LabelMap/test/itkLabelImageToLabelMapFilterTest.cxx

@@ -112,8 +112,7 @@ itkLabelImageToLabelMapFilterTest(int, char *[])
       IndexType index;
       index[0] = ctrI;
       index[1] = ctrJ;
-      unsigned long val;
-      val = map->GetPixel(index);
+      unsigned long val = map->GetPixel(index);
       std::cout << "Pixel[" << ctrI << ',' << ctrJ << "]: " << val << std::endl;
       if (((ctrI == 5) || (ctrJ == 5)) && (ctrI != 7) && (ctrJ != 7))
       {

Modules/Filtering/LabelMap/test/itkLabelMapToLabelImageFilterTest.cxx

@@ -82,8 +82,7 @@ itkLabelMapToLabelImageFilterTest(int argc, char * argv[])
       IndexType index;
       index[0] = ctrI;
       index[1] = ctrJ;
-      unsigned char val;
-      val = image->GetPixel(index);
+      unsigned char val = image->GetPixel(index);
       if ((ctrI == 5) || (ctrJ == 5))
       {
         itkAssertOrThrowMacro((val == 1), "Error in Label Image.");

Modules/Filtering/LabelMap/test/itkShiftLabelObjectTest.cxx

@@ -86,8 +86,7 @@ itkShiftLabelObjectTest(int argc, char * argv[])
       IndexType index;
       index[0] = ctrI;
       index[1] = ctrJ;
-      unsigned long val;
-      val = map->GetPixel(index);
+      unsigned long val = map->GetPixel(index);
       std::cout << "Pixel[" << ctrI << ',' << ctrJ << "]: " << val << std::endl;
       if ((ctrI == 5) || (ctrJ == 5))
       {

Modules/IO/NIFTI/test/itkNiftiImageIOTest.cxx

@@ -155,8 +155,7 @@ itkNiftiImageIOTest(int argc, char * argv[])
   }
   else // This is the mechanism for doing internal testing of all data types.
   {
-    int cur_return;
-    cur_return = MakeNiftiImage<char>(testFileName);
+    int cur_return = MakeNiftiImage<char>(testFileName);
     if (cur_return != 0)
     {
       std::cerr << "Error writing Nifti file type char" << std::endl;

Modules/Nonunit/IntegratedTest/test/itkMaximumDecisionRuleTest.cxx

@@ -35,16 +35,13 @@ itkMaximumDecisionRuleTest(int, char *[])
 
   MembershipVectorType membershipScoreVector;
 
-  double membershipScore1;
-  membershipScore1 = 0.1;
+  double membershipScore1 = 0.1;
   membershipScoreVector.push_back(membershipScore1);
 
-  double membershipScore2;
-  membershipScore2 = 0.5;
+  double membershipScore2 = 0.5;
   membershipScoreVector.push_back(membershipScore2);
 
-  double membershipScore3;
-  membershipScore3 = 1.9;
+  double membershipScore3 = 1.9;
   membershipScoreVector.push_back(membershipScore3);
 
   // the maximum score is the third component. The decision rule should

Modules/Nonunit/IntegratedTest/test/itkMaximumRatioDecisionRuleTest.cxx

@@ -35,21 +35,17 @@ itkMaximumRatioDecisionRuleTest(int, char *[])
 
   MembershipVectorType membershipScoreVector;
 
-  double membershipScore1;
-  membershipScore1 = 0.1;
+  double membershipScore1 = 0.1;
   membershipScoreVector.push_back(membershipScore1);
 
-  double membershipScore2;
-  membershipScore2 = 0.5;
+  double membershipScore2 = 0.5;
   membershipScoreVector.push_back(membershipScore2);
 
-  double membershipScore3;
-  membershipScore3 = 1.9;
+  double membershipScore3 = 1.9;
   membershipScoreVector.push_back(membershipScore3);
 
   // add discriminantscore with a value of zero
-  double membershipScore4;
-  membershipScore4 = 0.0;
+  double membershipScore4 = 0.0;
   membershipScoreVector.push_back(membershipScore4);
 
 

Modules/Nonunit/IntegratedTest/test/itkMinimumDecisionRuleTest.cxx

@@ -35,16 +35,13 @@ itkMinimumDecisionRuleTest(int, char *[])
 
   MembershipVectorType membershipScoreVector;
 
-  double membershipScore1;
-  membershipScore1 = 1.1;
+  double membershipScore1 = 1.1;
   membershipScoreVector.push_back(membershipScore1);
 
-  double membershipScore2;
-  membershipScore2 = 0.5;
+  double membershipScore2 = 0.5;
   membershipScoreVector.push_back(membershipScore2);
 
-  double membershipScore3;
-  membershipScore3 = 1.9;
+  double membershipScore3 = 1.9;
   membershipScoreVector.push_back(membershipScore3);
 
   // the minimum score is the third component. The decision rule should

Modules/Numerics/Statistics/test/itkDecisionRuleTest.cxx

@@ -86,16 +86,13 @@ itkDecisionRuleTest(int, char *[])
 
   MembershipVectorType membershipScoreVector;
 
-  double membershipScore1;
-  membershipScore1 = 0.1;
+  double membershipScore1 = 0.1;
   membershipScoreVector.push_back(membershipScore1);
 
-  double membershipScore2;
-  membershipScore2 = 0.5;
+  double membershipScore2 = 0.5;
   membershipScoreVector.push_back(membershipScore2);
 
-  double membershipScore3;
-  membershipScore3 = 1.9;
+  double membershipScore3 = 1.9;
   membershipScoreVector.push_back(membershipScore3);
 
   // the maximum score is the third component. The decision rule should

Modules/Numerics/Statistics/test/itkDistanceMetricTest.cxx

@@ -45,16 +45,14 @@ class MyDistanceMetric : public DistanceMetric<TMeasurementVector>
   double
   Evaluate(const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 
   double
   Evaluate(const TMeasurementVector &, const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 };

Modules/Numerics/Statistics/test/itkDistanceMetricTest2.cxx

@@ -45,16 +45,14 @@ class MyDistanceMetric : public DistanceMetric<TMeasurementVector>
   double
   Evaluate(const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 
   double
   Evaluate(const TMeasurementVector &, const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 };

Modules/Numerics/Statistics/test/itkMembershipFunctionBaseTest.cxx

@@ -49,8 +49,7 @@ class MyMembershipFunctionBase : public MembershipFunctionBase<TMeasurementVecto
   double
   Evaluate(const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 };

Modules/Numerics/Statistics/test/itkMembershipFunctionBaseTest2.cxx

@@ -49,8 +49,7 @@ class MyMembershipFunctionBase : public MembershipFunctionBase<TMeasurementVecto
   double
   Evaluate(const TMeasurementVector &) const override
   {
-    double score;
-    score = 1;
+    double score = 1;
     return score;
   }
 };

Modules/Numerics/Statistics/test/itkScalarImageToCooccurrenceMatrixFilterTest.cxx

@@ -284,8 +284,7 @@ itkScalarImageToCooccurrenceMatrixFilterTest(int, char *[])
     zero_zero[0] = 0;
     zero_zero[1] = 0;
 
-    float zzF;
-    zzF = hist2->GetFrequency(zero_zero);
+    float zzF = hist2->GetFrequency(zero_zero);
     totalF = hist2->GetTotalFrequency();
 
     if (itk::Math::NotAlmostEquals(zzF, 40.0f) || itk::Math::NotAlmostEquals(zzF, totalF))

Modules/Segmentation/Classifiers/test/itkSampleClassifierFilterTest7.cxx

@@ -165,8 +165,7 @@ itkSampleClassifierFilterTest7(int argc, char * argv[])
     const unsigned int measurementVectorSize = sample->GetMeasurementVectorSize();
     for (unsigned int j = 0; j < measurementVectorSize; ++j)
     {
-      double temp;
-      temp = (components[i])->GetFullParameters()[j] - trueParameters[i][j];
+      double temp = (components[i])->GetFullParameters()[j] - trueParameters[i][j];
       displacement += (temp * temp);
     }
     displacement = std::sqrt(displacement);

Modules/Segmentation/LevelSets/test/itkCannySegmentationLevelSetImageFilterTest.cxx

@@ -32,26 +32,24 @@ constexpr int V_DEPTH = 64;
 float
 sphere(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }
 
 float
 sphere2(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.1) * (x - static_cast<float>(V_WIDTH) / 2.1) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.1) * (x - static_cast<float>(V_WIDTH) / 2.1) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }
 

Modules/Segmentation/LevelSets/test/itkLaplacianSegmentationLevelSetImageFilterTest.cxx

@@ -33,26 +33,24 @@ constexpr int V_DEPTH = 64;
 float
 sphere(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }
 
 float
 sphere2(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.1) * (x - static_cast<float>(V_WIDTH) / 2.1) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.1) * (x - static_cast<float>(V_WIDTH) / 2.1) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }
 

Modules/Segmentation/LevelSets/test/itkLevelSetFunctionTest.cxx

@@ -45,9 +45,8 @@ const unsigned int WIDTH = (256);
 float
 circle(unsigned int x, unsigned int y)
 {
-  float dis;
-  dis = (x - static_cast<float>(WIDTH) / 2.0) * (x - static_cast<float>(WIDTH) / 2.0) +
-        (y - static_cast<float>(HEIGHT) / 2.0) * (y - static_cast<float>(HEIGHT) / 2.0);
+  float dis = (x - static_cast<float>(WIDTH) / 2.0) * (x - static_cast<float>(WIDTH) / 2.0) +
+              (y - static_cast<float>(HEIGHT) / 2.0) * (y - static_cast<float>(HEIGHT) / 2.0);
   dis = RADIUS - std::sqrt(dis);
   return dis;
 }

Modules/Segmentation/LevelSets/test/itkNarrowBandThresholdSegmentationLevelSetImageFilterTest.cxx

@@ -32,13 +32,12 @@ constexpr int V_DEPTH = 64;
 float
 sphere(float x, float y, float z)
 {
-  float dis;
-  dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
-          ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
-        (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
-          ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
-        (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
-          ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
+  float dis = (x - static_cast<float>(V_WIDTH) / 2.0) * (x - static_cast<float>(V_WIDTH) / 2.0) /
+                ((0.2f * V_WIDTH) * (0.2f * V_WIDTH)) +
+              (y - static_cast<float>(V_HEIGHT) / 2.0) * (y - static_cast<float>(V_HEIGHT) / 2.0) /
+                ((0.2f * V_HEIGHT) * (0.2f * V_HEIGHT)) +
+              (z - static_cast<float>(V_DEPTH) / 2.0) * (z - static_cast<float>(V_DEPTH) / 2.0) /
+                ((0.2f * V_DEPTH) * (0.2f * V_DEPTH));
   return (1.0f - dis);
 }