-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Poetry for dependency management system #182
base: master
Are you sure you want to change the base?
Added Poetry for dependency management system #182
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Also i don't think you have the latest version of the source. There are missing commits |
@pranavbaburaj so should I close this one and start another? |
@pranavbaburaj this is only one file right? It should not conflict. @pranavbaburaj can we make a new branch “semi” and @adii21-Ux will point to semi branch instead of master |
@GouravSardana I will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GouravSardana this feature can be enable to update pull request branches.
@adii21-Ux pytest
can be added as dev dependency using
poetry add -D pytest
simple-term-menu = "1.0.1" | ||
|
||
[tool.poetry.dev-dependencies] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be added to enable command line functionality
[tool.poetry.scripts] | |
dynamic = "dynamic.__main__:main" | |
{ include = "dynamic" }, | ||
{ include = "dynamic_cli.egg-info" }, | ||
{ include = "LICENSE" }, | ||
{ include = "poetry.lock" }, | ||
{ include = "pyproject.toml" }, | ||
{ include = "README.md" }, | ||
{ include = "setup.py" } | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these
description = "A Modern, user-friendly command-line HTTP client for the API testing, and if you're stuck - Search and browse StackOverflow without leaving the CLI" | ||
authors = ["IndianOpenSourceFoundation"] | ||
license = "General Public License GNU" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packages should be mentioned here
packages = [{ include = "dynamic" }] | |
No I think, as @GouravSardana not a big deal |
Related Issue
Closes: #161
Describe the changes you've made
Checklist:
Screenshots