-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Added xonsh shell in dynamic #167
[WIP]Added xonsh shell in dynamic #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉Congratulations!!🎉 for making your first PR , our mentors will review it soon.
@GouravSardana tests are failing. How can I resolve this? |
@sudojarvis Wait I'll review it, Will try it locally and give you some suggestions |
I pulled your PR locally but i couldn't activate the xonsh. Is there is something which I'm missing ? |
cc @sudojarvis |
Just to be sure - When i did "xonsh', It breaks |
@sudojarvis I tested the changes, suggestion from my end:
Do not worry about issue level. I'll make this as level 4 or 5 once you'll understand the scope of this. I hope this make sense. Please let me know if you required anything else from our side. cc @PradyumnaKrishna @pranavbaburaj |
yup got it. will Try to do it again. And will try to add features to it. |
SonarCloud Quality Gate failed. 21 Bugs No Coverage information |
Related Issue
Closes: #125
Describe the changes you've made
Added xonsh shell in dynamic.
Checklist:
Screenshots