Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xonsh shell in dynamic #125

Open
GouravSardana opened this issue Sep 30, 2021 · 13 comments
Open

Add xonsh shell in dynamic #125

GouravSardana opened this issue Sep 30, 2021 · 13 comments
Labels
Hacktoberfest This Issue Will be Consider Under Hacktoberfest 2021

Comments

@GouravSardana
Copy link
Member

We have to make autocomplete feature for dynamic. To make it work we need to create a xonsh shell. Still confused ?
Ref to this - xonsh

How does it actually works?

When a user types dynamic. It will redirect to a different shell on the same terminal and we can use autocomplete in that shell because our normal terminal doesn't allow you to autocomplete.

Ref first 1 sec of GIF [When he type gitsome, Another shell got popup [still confused? Tried installing gitsome in local and type gitsome in terminal]]-

endgoal

Credit for xonsh - xonsh
Credit for Gitsome - Gitsome

@GouravSardana GouravSardana added the hacktoberfest-accepted Good Work, Your Pull Request is Accepted for the Hacktoberfest label Sep 30, 2021
@Siddhant-K-code Siddhant-K-code added Hacktoberfest This Issue Will be Consider Under Hacktoberfest 2021 and removed hacktoberfest-accepted Good Work, Your Pull Request is Accepted for the Hacktoberfest labels Oct 6, 2021
@sudojarvis
Copy link

Hi, I would like to work on this issue. Could you please give some head start?
It would be helpful.

@GouravSardana
Copy link
Member Author

Go ahead buddy @sudojarvis

@sudojarvis
Copy link

sudojarvis commented Mar 3, 2022

@GouravSardana gitsome uses xonsh shell. I have to do a similar thing right?

@sudojarvis
Copy link

Do we have to do it from scratch or we can merge it from xonsh.

@GouravSardana
Copy link
Member Author

@sudojarvis That’s correct gitsome uses the xonsh shell.
no no, you don’t have to create it from scratch just leverage the xonsh and try to replicate the flow from gitsome

@sudojarvis
Copy link

@GouravSardana could you please assign the issue to me under GSSOC'22.

@GouravSardana
Copy link
Member Author

Np. Work on this issue. Don’t worry about assigning the issues. I’ll take care of that

@sudojarvis
Copy link

sudojarvis commented Mar 6, 2022

Kazam_screencast_00018.mp4

@GouravSardana Till now it is auto-completing, what I typed previously. But I have used code from gitsome. Is this fine?

@GouravSardana
Copy link
Member Author

@sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in gitsome.

  • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
  • Is this autocomplete based on our history or the argument which we have ?

@sudojarvis
Copy link

sudojarvis commented Mar 6, 2022

@sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in git

  • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
  • Is this autocomplete based on our history or the argument which we have ?

@GouravSardana yes, to 1st two questions. And updated the video watch from 2:35.

@sudojarvis
Copy link

  • Is this autocomplete based on our history or the argument which we have ?
    based on our history

@GouravSardana
Copy link
Member Author

Okay but i think this autocomplete should work based on both things. One is history and other is args.
As of now, can you make a PR, I’ll review it locally and will give you suggestions accordingly

@GouravSardana
Copy link
Member Author

@sudojarvis Any update ?

@sudojarvis sudojarvis removed their assignment Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest This Issue Will be Consider Under Hacktoberfest 2021
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants