Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cache utilization of pagination #958

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Improve cache utilization of pagination #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion isic/core/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def paginate_queryset(
# If we have an offset cursor then offset the entire page by that amount.
# We also always fetch an extra item in order to determine if there is a
# page following on from this one.
results = list(queryset[cursor.offset : cursor.offset + limit + 1])
# Always fetch the maximum page size to increase cache utilization.
results = list(queryset[cursor.offset : cursor.offset + self.max_page_size + 1])
page = list(results[:limit])

# Determine the position of the final item following the page.
Expand Down
Loading