Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basket::setObjects: Reset $chosenObjects property only if the given objects is empty #2902

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

raviks789
Copy link
Collaborator

fix #2901

@raviks789 raviks789 self-assigned this Aug 5, 2024
@cla-bot cla-bot bot added the cla/signed label Aug 5, 2024
@raviks789 raviks789 changed the title Basket: Do not reset $chosenObjects property if already set Basket: Do not reset $chosenObjects property if already set and loaded from DB Aug 5, 2024
@raviks789 raviks789 changed the title Basket: Do not reset $chosenObjects property if already set and loaded from DB Basket: Do not reset $chosenObjects property in setObjects method if objects are not empty Aug 5, 2024
@raviks789 raviks789 force-pushed the fix/basket-custom-selection-resubmit branch 2 times, most recently from b099f71 to ad95cd2 Compare August 5, 2024 10:31
@raviks789 raviks789 changed the title Basket: Do not reset $chosenObjects property in setObjects method if objects are not empty Basket::setObjects: Reset $chosenObjects property only if the given objects is empty Aug 5, 2024
@raviks789 raviks789 added this to the v1.11.2 milestone Aug 13, 2024
@raviks789 raviks789 force-pushed the fix/basket-custom-selection-resubmit branch from ad95cd2 to 02e8ab5 Compare October 22, 2024 14:44
@lippserd lippserd force-pushed the fix/basket-custom-selection-resubmit branch from 02e8ab5 to 6be8cd4 Compare November 7, 2024 10:14
@lippserd lippserd merged commit 39c823c into master Nov 7, 2024
15 checks passed
@lippserd lippserd deleted the fix/basket-custom-selection-resubmit branch November 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit button resets basket content to empty
2 participants