-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module.less: Fix align of action-bar and sort control #441
Conversation
65f0556
to
a8fd0c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the exact problem is fixed, the action-bar is still a complete mess, when the column is too narrow. We should fix that, when we're currently working on the module.
Please decide for yourself, if you want to fix it in this PR or create another one.
I'd suggest the following:
- Use the regular font-size (1em)
- Prevent labels (plus icons) from line breaks
- Ellipsisize labels, when too narrow
- Add title for making ellipsisized label content accessible
- Use proper spacing between element rows, when the flex-container wraps
See Icinga DB Web's quick action bar for reference.
a8fd0c8
to
170a51c
Compare
I have fixed it according to your suggestions, except for the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so far.
Please remove the font-size attribute in line 13 (see in line comment).
As for the line-breaks. You are right, the flex wrap happens before the line-break. So that's fine.
170a51c
to
e8859ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please apply the right margin of the last item and the overall bottom margin to the container, not the items.
- the first item should not have a left margin
e8859ae
to
7418a72
Compare
7418a72
to
8525516
Compare
Use regular font-size (1em) for action-bar
8525516
to
42c724d
Compare
fixes #421