Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket6085 add IOC Thorlabs FW102C #890

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iangillingham-stfc
Copy link
Contributor

@iangillingham-stfc iangillingham-stfc commented Nov 7, 2024

Description of work

Added new device IOC and support for Thorlabs FW102C

To test

Which ticket does this PR fix? HIFI: IOC & OPI for Thorlabs Filter Wheel

Acceptance criteria

IOC tests pass:
C:\Instrument\Apps\EPICS\support\thorlabsfw102c\master\system_tests
run_tests.bat -a


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant