Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.xml #642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davidkeymer
Copy link
Contributor

Correct regular expression for checking ramp file name. Previously it failed due to . separator.

Description of work

As above

To test

None - flash review

Acceptance criteria

Filename of up to 40 characters including extension ("36.3") using alphanumeric (with underscore) passes regex check in macro configuration in client.


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

Correct regular expression for checking ramp file name.  Previously it failed due to `.` separator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant