-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket5481 all iocs at least 2 numbers #509
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 219f087.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the additional IOCs boot due to incomplete templates. Can we make sure we run the ioc tests (where they exist) for newly-created _02
iocs to make sure they actually work
AG33220A_IOC_02_registerRecordDeviceDriver pdbbase | ||
|
||
## calling common command file in ioc 01 boot dir | ||
< ${TOP}/iocBoot/ioc_01_APP_NAME_/st-common.cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs filling in. This means the ioc can't boot and the ioc tests for ioc _02 fail.
This is also true for all of the other IOCs in this PR.
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this second IOC makes sense as it is an LvDCOM and only has one underlying vi?
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second IOC doesn't make sense for this device as it's an lvdcom of a single underlying vi
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this second IOC makes sense as no beamline at ISIS has multiple fermi choppers.
Additionally I think this has some C code/SNL in the ioc dir which would need moving to the support module to get a second IOC to work I think.
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, no beamline at ISIS has multiple fermi choppers so I don't think this second IOC makes sense
GEMORC/GEMORC-IOC-02App/Db/Makefile
Outdated
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't make sense to have multiple IOCs for this device, it's impossible to physically have more than one ORC on the beamline. Additionally there is only one of these devices in existence (on GEM)
@@ -0,0 +1,18 @@ | |||
TOP=../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one of this device physically exists - probably doesn't make sense to have multiple IOCs.
This reverts commit a4a3c78.
Description of work
Added second numbered IOC to various IOCs
To test
partially, #5481
Acceptance criteria
Second IOCs added correctly
Code Review
Functional Tests
..._0n
wheren>1
) run correctlymacLib: macro
to find instances ofmacLib: macro [macro name] is undefined...
Final steps