Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket8310 eurothrm disconnected sensor #177

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Ticket8310 eurothrm disconnected sensor #177

wants to merge 27 commits into from

Commits on May 30, 2024

  1. Add eurotherm sensor class to handle multiple sensors and instances o… 

    …f simulated eurotherm class
    @esmith1729
    esmith1729 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d06c668 View commit details
    Browse the repository at this point in the history

  2. further refactoring

    @esmith1729
    esmith1729 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    87cc85d View commit details
    Browse the repository at this point in the history

  3. refactor and include missing attribute get and sets

    @esmith1729
    esmith1729 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    597de02 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Add more get and set to simulated eurotherm for eurothermsensor attri… 

    …butes
    @esmith1729
    esmith1729 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    45fe3ed View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Remove all "_" attributes, add get and set for all attributes of Euro… 

    …thermSensor
    @esmith1729
    esmith1729 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c9a309e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Add addr params to methods, and add new methods for output_rate and o… 

    …thers
    @esmith1729
    esmith1729 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    15b0f46 View commit details
    Browse the repository at this point in the history

  2. Change regex to escape to ensure strings aren't passed or modified

    @esmith1729
    esmith1729 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    48e4f4e View commit details
    Browse the repository at this point in the history

  3. Change eurothermSensor's initialize data to __init__, renumber and re… 

    …name sensors
    @esmith1729
    esmith1729 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    593eeda View commit details
    Browse the repository at this point in the history

  4. add delay_time to initialize data to fix delay not being attribute error 

    Co-authored-by: Jack Harper <[email protected]>
    @esmith1729 @rerpha
    esmith1729 and rerpha committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4de8317 View commit details
    Browse the repository at this point in the history

  5. made value a string to avoid concatenation error

    @esmith1729
    esmith1729 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    aff1c62 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. rename connected to avoid uncallable being exposed; add type conversi… 

    …ons to all gets and sets to assure they are right type before assignment.
    @esmith1729
    esmith1729 committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0c7c081 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. add bool value

    @esmith1729
    esmith1729 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a0bffe8 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. change cmds to not cast to int

    @esmith1729
    esmith1729 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2e763f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. create set_delay_time to allow for some tests to change it

    @esmith1729
    esmith1729 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    585f619 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Change some typos, remove print statements

    @esmith1729
    esmith1729 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cc46a45 View commit details
    Browse the repository at this point in the history

  2. remove print statement

    @esmith1729
    esmith1729 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b76dca4 View commit details
    Browse the repository at this point in the history

  3. Change all set functions to use the set method in device.py, and all … 

    …get methods to pass the sensor value to device.py
    @esmith1729
    esmith1729 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5e5fe40 View commit details
    Browse the repository at this point in the history

  4. Change modbus values from int to string

    @esmith1729
    esmith1729 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d61babe View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Ammend data types for needlevalve attributes

    @esmith1729
    esmith1729 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1a8650b View commit details
    Browse the repository at this point in the history

  2. Add reference to sensor, since device.py now handles attributes with … 

    …getter and setter methods
    @esmith1729
    esmith1729 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fc3d96c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Revert changes of type float back to int, as modbus interface can onl… 

    …y handle int, add type safe type references for log_replies method
    @esmith1729
    esmith1729 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    66b7ba4 View commit details
    Browse the repository at this point in the history

  2. Change type from int to float

    @esmith1729
    esmith1729 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    17351bf View commit details
    Browse the repository at this point in the history

  3. return output_rate to int

    @esmith1729
    esmith1729 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ee81bac View commit details
    Browse the repository at this point in the history

  4. Add type hints and init method, formatting for ruff and pyright changes

    @esmith1729
    esmith1729 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c8828f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Refactor for ruff/pyright

    @esmith1729
    esmith1729 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    95be48d View commit details
    Browse the repository at this point in the history

  2. output_rate needs to be int for modbus_interface

    @esmith1729
    esmith1729 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    add8d44 View commit details
    Browse the repository at this point in the history

  3. Ruff change

    @esmith1729
    esmith1729 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1f337a1 View commit details
    Browse the repository at this point in the history