Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change scraping logic for ICRC website #2288

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix: Change scraping logic for ICRC website #2288

merged 1 commit into from
Nov 4, 2024

Conversation

susilnem
Copy link
Member

Addresses

Changes

  • This PR is related to the command api/management/commands/ingest_icrc.py
  • Change the ingestion logic
  • Need to run the command python manage.py ingest_icrc

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

szabozoltan69
szabozoltan69 reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@szabozoltan69 szabozoltan69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes <3

@susilnem susilnem force-pushed the fix/ingest-icrc branch 2 times, most recently from 84366bc to f9bfb57 Compare October 23, 2024 12:39
@susilnem susilnem marked this pull request as ready for review October 24, 2024 10:12
@szabozoltan69
Copy link
Contributor

Should we merge this?

@szabozoltan69 szabozoltan69 merged commit 965d40f into develop Nov 4, 2024
3 checks passed
@szabozoltan69 szabozoltan69 deleted the fix/ingest-icrc branch November 4, 2024 13:07
@szabozoltan69
Copy link
Contributor

Deployed to Staging

@susilnem
Copy link
Member Author

susilnem commented Nov 4, 2024

hey @szabozoltan69
we also need to run this command python manage.py ingest_icrc

@szabozoltan69
Copy link
Contributor

Done:

~/go-api# python manage.py ingest_icrc
2024-11-04 15:00:22 INFO     Starting ICRC data ingest
2024-11-04 15:01:10 INFO     77 ICRC added
2024-11-04 15:01:10 WARNING  instance does not have an es_id() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@szabozoltan69 szabozoltan69 szabozoltan69 approved these changes

@thenav56 thenav56 Awaiting requested review from thenav56

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susilnem @szabozoltan69 @Rup-Narayan-Rajbanshi