-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDRS: Fetch only the latest year related data #2280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabozoltan69
approved these changes
Oct 3, 2024
thenav56
requested changes
Oct 7, 2024
susilnem
force-pushed
the
fix/fdrs-latest-year-data
branch
2 times, most recently
from
October 7, 2024 14:39
dda3075
to
45a6f6a
Compare
thenav56
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until approval from QA
susilnem
force-pushed
the
fix/fdrs-latest-year-data
branch
from
October 8, 2024 05:09
45a6f6a
to
61ad6b3
Compare
szabozoltan69
force-pushed
the
develop
branch
2 times, most recently
from
October 8, 2024 12:54
14cb672
to
682a280
Compare
susilnem
requested review from
szabozoltan69,
thenav56 and
Rup-Narayan-Rajbanshi
October 23, 2024 18:37
Rup-Narayan-Rajbanshi
approved these changes
Oct 24, 2024
szabozoltan69
approved these changes
Oct 24, 2024
Should we merge this? |
@szabozoltan69 |
Both were run fine (ingest_databank had a slight issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
KPI_noLocalUnits
changed toKPI_noBranches
This pull request's related to
databank/management/commands/sources/FDRS.py
.Need to run these commands.
python manage.py ingest_databank
andpython manage.py ingest_worldbank
Improvements to data fetching and processing:
Changed the key from
KPI_noLocalUnits
toKPI_noBranches
.Updated the
prefetch
function to fetch the latest data for each indicator by using themax
function to get the entry with the highest year. (databank/management/commands/sources/FDRS.py
)Modified the
load
function to ensure only the latest year's available data is used by checking the year before setting the value. (databank/management/commands/sources/FDRS.py
)Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.