Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest data from world bank data for country overview #2230

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

Rup-Narayan-Rajbanshi
Copy link
Collaborator

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Aug 2, 2024

Addresses

Changes

  • Add latest data from World Bank API for country overview.
  • Add colorlog for development console
  • Add helper for logger context

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title Get latest data from world bank data for country overview. WIP: Get latest data from world bank data for country overview. Aug 2, 2024
@samshara samshara changed the title WIP: Get latest data from world bank data for country overview. WIP: Get latest data from world bank data for country overview Aug 2, 2024
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/world-bank-data-issue branch 3 times, most recently from fab3904 to b562495 Compare August 6, 2024 04:34
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title WIP: Get latest data from world bank data for country overview Get latest data from world bank data for country overview Aug 6, 2024
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/world-bank-data-issue branch 5 times, most recently from a9922be to 5632f3d Compare August 7, 2024 06:23
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/world-bank-data-issue branch 3 times, most recently from c4e5304 to 445aefe Compare August 9, 2024 07:53
@samshara samshara marked this pull request as ready for review August 14, 2024 05:40
@samshara samshara marked this pull request as draft August 14, 2024 05:42
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rup-Narayan-Rajbanshi Let's add some notes on refactor required

XXX: Using char to store integer values, Need to refactor the column type

Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samshara
Copy link
Member

samshara commented Aug 15, 2024

@Rup-Narayan-Rajbanshi It seems we haven't update the year of latest data

    "world_bank_population": 42239854,
    "calculated_world_bank_population_year": null,
    "world_bank_population_above_age_65": 1011704,
    "calculated_world_bank_population_above_age_65_year": null,
    "world_bank_population_age_14": 18097715,
    "calculated_world_bank_population_age_14_year": null,
    "world_bank_urban_population_percentage": 26.933,
    "calculated_world_bank_urban_population_percentage_year": null,
    "world_bank_gdp": 14502158192.0904,
    "calculated_world_bank_gdp_year": null,
    "world_bank_gni": 14545219074.5763,
    "calculated_world_bank_gni_year": null,
    "world_bank_gender_inequality_index": 1.0,
    "calculated_world_bank_gender_inequality_index_year": null,
    "world_bank_life_expectancy": 62,
    "calculated_world_bank_life_expectancy_year": null,
    "world_bank_literacy_rate": 37.266040802002,
    "calculated_world_bank_literacy_rate_year": null,
    "world_bank_poverty_rate": 54.5,
    "calculated_world_bank_poverty_rate_year": null,
    "world_bank_gni_capita": 360,
    "calculated_world_bank_gni_capita_year": null,

@Rup-Narayan-Rajbanshi
Copy link
Collaborator Author

@Rup-Narayan-Rajbanshi It seems we haven't update the year of latest data

    "world_bank_population": 42239854,
    "calculated_world_bank_population_year": null,
    "world_bank_population_above_age_65": 1011704,
    "calculated_world_bank_population_above_age_65_year": null,
    "world_bank_population_age_14": 18097715,
    "calculated_world_bank_population_age_14_year": null,
    "world_bank_urban_population_percentage": 26.933,
    "calculated_world_bank_urban_population_percentage_year": null,
    "world_bank_gdp": 14502158192.0904,
    "calculated_world_bank_gdp_year": null,
    "world_bank_gni": 14545219074.5763,
    "calculated_world_bank_gni_year": null,
    "world_bank_gender_inequality_index": 1.0,
    "calculated_world_bank_gender_inequality_index_year": null,
    "world_bank_life_expectancy": 62,
    "calculated_world_bank_life_expectancy_year": null,
    "world_bank_literacy_rate": 37.266040802002,
    "calculated_world_bank_literacy_rate_year": null,
    "world_bank_poverty_rate": 54.5,
    "calculated_world_bank_poverty_rate_year": null,
    "world_bank_gni_capita": 360,
    "calculated_world_bank_gni_capita_year": null,

I did run ingest_worldbank mgmt task. Now it working fine.

@thenav56 thenav56 force-pushed the feature/world-bank-data-issue branch 3 times, most recently from 9e000a2 to b3a7516 Compare August 18, 2024 12:34
@thenav56 thenav56 force-pushed the feature/world-bank-data-issue branch 2 times, most recently from 682bed8 to fc5c2cc Compare August 18, 2024 15:21
- Add custom logging configuration on debug
    - Preview logger->extra->context on console
@thenav56 thenav56 force-pushed the feature/world-bank-data-issue branch from d7da463 to 079844e Compare August 21, 2024 12:04
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/world-bank-data-issue branch 7 times, most recently from 5c1b7d0 to c013eff Compare August 23, 2024 04:30
@szabozoltan69
Copy link
Contributor

@Rup-Narayan-Rajbanshi should we merge it to develop (and deploy to Staging)?

@szabozoltan69
Copy link
Contributor

@samshara should we merge it to develop (and deploy to Staging)?

@thenav56
Copy link
Member

@szabozoltan69 Yes, let's do it. Thanks

@szabozoltan69 szabozoltan69 marked this pull request as ready for review August 26, 2024 11:17
@szabozoltan69 szabozoltan69 merged commit bc254b6 into develop Aug 26, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/world-bank-data-issue branch August 26, 2024 11:17
@szabozoltan69
Copy link
Contributor

@thenav56 – Done, also the deployment to Staging.

@szabozoltan69
Copy link
Contributor

Running migrations:
  Applying databank.0026_countryoverview_calculated_world_bank_gdp_year_and_more... OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants