-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest data from world bank data for country overview #2230
Conversation
b9253b0
to
0dc2d6b
Compare
fab3904
to
b562495
Compare
a9922be
to
5632f3d
Compare
c4e5304
to
445aefe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rup-Narayan-Rajbanshi Let's add some notes on refactor required
XXX: Using char to store integer values, Need to refactor the column type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
445aefe
to
7c15c0f
Compare
@Rup-Narayan-Rajbanshi It seems we haven't update the year of latest data
|
I did run ingest_worldbank mgmt task. Now it working fine. |
9e000a2
to
b3a7516
Compare
682bed8
to
fc5c2cc
Compare
- Add custom logging configuration on debug - Preview logger->extra->context on console
d7da463
to
079844e
Compare
- Typo fixes
5c1b7d0
to
c013eff
Compare
c013eff
to
c9522f0
Compare
@Rup-Narayan-Rajbanshi should we merge it to develop (and deploy to Staging)? |
@samshara should we merge it to develop (and deploy to Staging)? |
@szabozoltan69 Yes, let's do it. Thanks |
@thenav56 – Done, also the deployment to Staging. |
|
Addresses
Changes
Checklist
Things that should succeed before merging.