Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NS directory and Capacity Issue #2214

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Jul 12, 2024

Addresses:

  • Data repetition for NS capacity
  • NS Directory is Showing None

Changes

  • Add unique together for NS capacity
  • Delete NS Directory
  • Add new migrations

Note: Need to run the following commands manually:

- ./manage.py ingest_ns_capacity
- ./manage.py ingest_ns_directory

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem requested a review from thenav56 July 12, 2024 06:49
@susilnem susilnem force-pushed the fix/country_directory_issue branch from 5e3dee1 to 4693d06 Compare July 12, 2024 06:52
api/management/commands/ingest_ns_capacity.py Show resolved Hide resolved
api/management/commands/ingest_ns_capacity.py Show resolved Hide resolved
api/models.py Outdated Show resolved Hide resolved
api/management/commands/ingest_ns_directory.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the fix/country_directory_issue branch from 4693d06 to 5aecbc5 Compare July 12, 2024 08:03
@susilnem susilnem requested a review from thenav56 July 12, 2024 08:19
@susilnem susilnem force-pushed the fix/country_directory_issue branch 2 times, most recently from 567d7bf to 29cc202 Compare July 12, 2024 09:15
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szabozoltan69 When you have time, could you review and merge this?

NOTE: We need to run this command after deployment

./manage.py ingest_ns_capacity
./manage.py ingest_ns_directory

@thenav56 thenav56 marked this pull request as ready for review July 12, 2024 09:29
@szabozoltan69 szabozoltan69 merged commit 631d73e into develop Jul 15, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the fix/country_directory_issue branch July 15, 2024 09:01
@szabozoltan69
Copy link
Contributor

Deployed to Staging.
The ingest_ns_capacity had some

  warnings.warn(
/usr/local/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1595: RuntimeWarning: DateTimeField CountryCapacityStrengthening.submission_date received a naive datetime (2019-01-20 00:00:00) while time zone support is active.

warnings, but run fine.
ingest_ns_directory also run fine, giving: "1647 Ns Directory added".

@szabozoltan69
Copy link
Contributor

szabozoltan69 commented Jul 15, 2024

@thenav56 ^ commands were run on Staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants