Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up StrategicPriority & MembershipCoordination on import #2182

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Jun 21, 2024

Addresses Legacy dataset
Related to:

Changes

  • Clean-up existing dataset (StrategicPriority & MembershipCoordination)
  • Add transaction.atomic over whole import process

- Add transaction.atomic over whole import process
@thenav56 thenav56 force-pushed the feature/country-plan-import-clean-up branch from abeed64 to fe06502 Compare June 21, 2024 10:41
@thenav56 thenav56 marked this pull request as ready for review June 21, 2024 10:44
@thenav56
Copy link
Member Author

Hey @szabozoltan69, Could you review this PR? This should fix the inconsistency in Strategic dashboard mentioned by @tovari.

Copy link
Contributor

@szabozoltan69 szabozoltan69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one.

@szabozoltan69 szabozoltan69 merged commit d9bbb0c into develop Jun 21, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/country-plan-import-clean-up branch June 21, 2024 10:52
@szabozoltan69
Copy link
Contributor

Merged and deployed to Staging, also https://goadmin-stage.ifrc.org/en/admin/country_plan/dataimport/ used afterwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants