Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Molnix positions instead of only /open #2172

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

szabozoltan69
Copy link
Contributor

Refers to #2169

@szabozoltan69 szabozoltan69 marked this pull request as draft June 12, 2024 15:07
@szabozoltan69 szabozoltan69 force-pushed the fix/molnix-issue-2169 branch 3 times, most recently from e661e3c to eb26600 Compare June 12, 2024 16:34
@batpad
Copy link
Collaborator

batpad commented Jun 13, 2024

@szabozoltan69 does this significantly increase the time it takes to process the Molnix records? i.e. if there are lots of historical records, then just maybe this makes it very slow and we need to reconsider. If it does not, then this looks good to me!

Do we have a good way to test this carefully on current production data or so to make sure it does not do anything unexpected?

Otherwise, this looks good to me!

@szabozoltan69
Copy link
Contributor Author

szabozoltan69 commented Jun 14, 2024

@batpad I don't know any sharp method for thorough testing. The runs: 5:00 / 8:41 the old and the new one. It would be fine to "hunt" to a test case that is missing in the old workflow and could be found according to the new one.
Maybe this new one could be another cron job (or could be chosen via a switch, like --fullscan).

@tovari
Copy link

tovari commented Jun 14, 2024

@szabozoltan69, @batpad I guess, we need to run this not more frequently than once a day

@szabozoltan69 szabozoltan69 marked this pull request as ready for review June 18, 2024 09:24
@szabozoltan69 szabozoltan69 merged commit 10ce09a into develop Jun 18, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the fix/molnix-issue-2169 branch June 18, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants