Add subscription alert detail page #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshathakuri
requested review from
tnagorra,
frozenhelium,
AdityaKhatri,
samshara and
roshni73
AdityaKhatri
requested changes
Nov 19, 2024
Comment on lines
110
to
111
| {alertsDetail?.map((filters) => ( | ||
| <div className={styles.badgeContainer}> | ||
| {filters.alertFilter?.map((filter) => ( | ||
| <div | ||
| className={styles.badge} | ||
| > | ||
| {filter} | ||
| </div> | ||
| ))} | ||
| </div> | ||
| ))} | ||
| <List | ||
| className={styles.alertItem} | ||
| data={alertInfo} |
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
1c076f4
to
5ff7a37
Compare
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
5ff7a37
to
00a9601
Compare
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
00a9601
to
413bb08
Compare
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
413bb08
to
a174487
Compare
AdityaKhatri
requested changes
Nov 21, 2024
Comment on lines
1
to
26
| import { Container } from '@ifrc-go/ui'; | ||
|
|
||
| import styles from './styles.module.css'; | ||
|
|
||
| interface Props { | ||
| alertId: string; | ||
| alertFilters: string; | ||
| } | ||
|
|
||
| function SubscriptionFilters(props: Props) { | ||
| const { | ||
| alertId, | ||
| alertFilters, | ||
| } = props; | ||
|
|
||
| return ( | ||
| <Container | ||
| className={styles.badge} | ||
| key={alertId} | ||
| > | ||
| {alertFilters} | ||
| </Container> | ||
| ); | ||
| } | ||
|
|
||
| export default SubscriptionFilters; |
There was a problem hiding this comment.
Change this into a common component and call it Badge
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
a174487
to
c762f07
Compare
barshathakuri
force-pushed
the
feature/subscription-detail
branch
from
c762f07
to
d54d2a6
Compare
AdityaKhatri
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging