Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vocabulary class #258

Open
wants to merge 245 commits into
base: main
Choose a base branch
from
Open

Add Vocabulary class #258

wants to merge 245 commits into from

Conversation

orviz
Copy link
Collaborator

@orviz orviz commented Nov 6, 2024

Includes vocabularies for IANA media types and FAIRSharing

orviz added 30 commits May 23, 2024 09:07
@orviz
Remove unnecessary variable
fea5aee
@orviz
Use logging.info instead of print()
7d09b7b
@orviz
Search option available also for epos prod
66ccfc9
@orviz
First implementation (copy from EPOS) of EPOS prod plugin
8ac821e
@orviz
Fix: remove unnecessary local 'eml_schema' var
54ee186
@orviz
Initial config.ini for epos_prod plugin
a8eb6e1
@orviz
Minimum implementation & config for EPOS prod API
2231cc7
@orviz
Align ID term list for both EPOS plugins
fac54d0
@orviz
Avoid re-implementations on EPOS prod side
18d873e
@orviz
Reuse 'terms_cv', so terms_vocabularies -> terms_cv
56ce714
@orviz
Separate metadata value parsing in a individual class PluginUtils
d944c68
@orviz
Different implementations to ge the IDs for the data in EPOS prod and…
341b4a0 
… dev
@orviz
Basic structure for metadata value gathering and validation
c3d3352
@orviz
Reimplement i1_01m with PluginUtils (leaving commented code).
c1ebb24
@orviz
Support for gathering list of file formats from metadata
4086b8b
@orviz
Support for gathering list of temporal coverage from metadata
1aa6e99
@orviz
Support for gathering list of licenses from metadata
f7e30b2
@orviz
Implementation of metadata value validation (incl. licensing) as part…
e17d9bf 
… of PluginUtils
@orviz
Add new attributes for CVs
851b66d
@orviz
Common way to gather non-validated results
dfd5365
@orviz
Fix: method naming
b8583ae
@orviz
Minor comment
6a5f245
@orviz
Fix: docstrings
0a3aedd
@orviz
Fix: duplicate config
60860e5
@orviz
Implement MetadataValuesBase as parent class
a296dc5
@orviz
Include identifiers in the gathering process
471d5d4
@orviz
Typo
7cc1de0
@orviz
Sort elements
f161484
@orviz
Methods from MetadataValuesBase class that shall be implemented by ch…
90bbaab 
…ildren classes
@orviz
Fix: get config value
1ca1395
@orviz
Raise exception if given argument is not an orcid
880f8ba
@orviz
Raise exception if 'controlled_vocabularies' is not defined in config…
5ee64d8 
…uration
@orviz
Fix: remove not used imported module
e8e820e
@orviz
Move 'dublin-core' section to main config.ini
f86d90a
@orviz
Fix: evaluation_logs logger
004325d
@orviz
Fix temporary elements for 'terms_access'
1ceb52c
@orviz
Return 100 points in ANY of the (identifier, downloadURL) resolves to…
6375966 
… a valid URL
@orviz
Fix in class method call
8eb93fa
@orviz
Clean up unused config parameters & duplicated code
902f8b4
@orviz
Merge branch 'release/3.0.0' of github.com:eosc-synergy/FAIR_eva into…
0187a5e 
… release/3.0.0
@orviz
Merge pull request #212 from EOSC-synergy/release/3.0.0
29e2cb5 
New release 3.0.0: FAIR report in DT-GEO's D4.1v2
@orviz
Fix: temporary coverage
a185da0
@orviz
Fix: warning in pre-commit
e962727
@orviz
Temporarily comment docformatter check
c1f61ad
@orviz
Remove old isort
7289736
@orviz
Format fix
15d483c
@orviz
Merge pull request #225 from EOSC-synergy/release/3.0.1
5e5ecb0 
Fix: temporary coverage
@orviz
Use docformatter last master version that fixes PyCQA/docformatter#287
56ccf24
@orviz
Merge pull request #226 from EOSC-synergy/release/3.0.2
6619716 
Use docformatter to latest master version
@orviz
Fix: gather 'start_date' and 'end_date' as part of temporal coverage …
a4fd79b 
…gathering
@orviz
Fix: exception catched when attempting to request an external resource
64709c8
@orviz
Fix: better handling of non-URI values
072be11
@orviz
Do not fail when TimeoutError exception is raised
d0c24ef
@orviz
Merge pull request #227 from EOSC-synergy/release/3.0.3
0115207 
Fix: gather 'start_date' and 'end_date' as part of temporal coverage …
@orviz
Merge last version of main branch (version 3.0.3) & Fix isort issue
7097d03
@orviz orviz requested a review from ferag as a code owner November 6, 2024 10:16
@orviz orviz requested review from ferag and removed request for ferag November 6, 2024 10:17
@ferag
Copy link
Collaborator

ferag commented Nov 12, 2024

Is terms_map now mandatory?
I have also some issues with plugin.metadata_utils. I'm not sure how it should work.

@orviz
Copy link
Collaborator Author

orviz commented Nov 12, 2024

Is terms_map now mandatory? I have also some issues with plugin.metadata_utils. I'm not sure how it should work.

  • terms_map should be defined in the plugin's config.ini. It should contain the mappings of the plugin's metadata schema and the ones used internally
  • the metadata_utils property has to be defined as a method in the plugin class (probably there is a smarter way to do it). This property returns the class that implements the gather methods of the plugin. So this is again something that is specific to the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferag ferag Awaiting requested review from ferag ferag is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orviz @ferag @PalomoIFCA