Fix set_parameter_path
in Helmholtz Property Package
#1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fix the set_parameter_path() function in helmholtz.
update
helmholtz_functions.py
andhelmholtz_state.py
to use the latest cfg variable rather than storing a copySummary/Motivation:
the set_parameter_path function does not properly update the helmholtz parameter file path, because it sets
idaes.properties.helmholtz.parameter_file_path
rather thanidaes.cfg.properties.parameter_file_path
(note .cfg).Also,
helmholtz_functions.py
makes a copy of the cfg variable into _data_dir, which also is not updated with set_parameter_path.This involves needing to do some hacky workarounds to specify a different directory to load helmholtz data from (e.g see my register_compounds function.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: