Unifying the use and calculation of QSO luminosity #18
Conversation
Reviewer's Guide by SourceryThis pull request unifies the use and calculation of QSO luminosity by removing the need to recalculate AGN luminosities in File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @MBravoS - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
standard_plots/qso_lf.py
Outdated
|
|
||
| if(read_spin): | ||
| (h0, volh, MBH, bh_accretion_rate_hh, bh_accretion_rate_sb, BH_spin) = hdf5_data | ||
| else: |
There was a problem hiding this comment.
issue: Unused variable vol
The variable vol is calculated but not used in the function. Consider removing it if it is not needed.
standard_plots/qso_lf.py
Outdated
| if(read_spin): | ||
| (h0, volh, MBH, bh_accretion_rate_hh, bh_accretion_rate_sb, BH_spin) = hdf5_data | ||
| else: | ||
| (h0, volh, MBH, bh_accretion_rate_hh, bh_accretion_rate_sb) = hdf5_data |
There was a problem hiding this comment.
issue: Changed L_bol calculation
The calculation of L_bol has been simplified. Ensure that this change does not affect the handling of edge cases where L_bol might be zero or negative.
Both the calculation of CO SLEDs and AGN bolometric LFs use the AGN luminosities. Previously this had to be recalculated as we didn't save the AGN luminosities in the Shark outputs. With their recent addition to the outputs in 24f0d89 (along with other properties) we can simplify both calculate_co_emission.py and lf_qso.py to just read the saved AGN luminosities instead of recalculating them. This also fixes the current inconsistency between both recalculations, as the one currently in calculate_co_emission.py doesn't take BH spin into account.
Summary by Sourcery
This pull request unifies the use and calculation of AGN luminosities by leveraging precomputed values from Shark outputs, thereby simplifying the code and ensuring consistency across different modules.