Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Doxygentest #60

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Doxygentest #60

wants to merge 6 commits into from

Conversation

llwang00
Copy link
Collaborator

@llwang00 llwang00 commented Nov 2, 2020

Please review. This is only for branch of 'doxygentest', will change to 'master' later.

Copy link
Collaborator

@james-strauss-uwa james-strauss-uwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we should move the xml2palette.py code into an ICRAR repo.

@llwang00 llwang00 requested a review from calgray November 3, 2020 06:29
Copy link
Collaborator

@calgray calgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a need for supporting html doxygen generation?

@llwang00
Copy link
Collaborator Author

llwang00 commented Nov 4, 2020

Is there still a need for supporting html doxygen generation?

I don't think so.

@llwang00 llwang00 requested a review from rtobar November 5, 2020 04:49
Copy link
Contributor

@rtobar rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me -- with the caveat that Travis builds are not running at the moment given their change in pricing strategy. When/if they run again in the future we'll also need to add the corresponding secure environment variables in the Travis settings for this repository so that the git push command actually works.

@llwang00
Copy link
Collaborator Author

llwang00 commented Nov 5, 2020

Looks fine to me -- with the caveat that Travis builds are not running at the moment given their change in pricing strategy. When/if they run again in the future we'll also need to add the corresponding secure environment variables in the Travis settings for this repository so that the git push command actually works.

Ok, thanks.

@james-strauss-uwa
Copy link
Collaborator

Since Travis CI is not running, I have ported this pipeline to a GitHub Action. The new action is in yan-494, so this branch is probably no longer necessary.

Thanks for the work though, the GitHub Action is almost a direct copy of this.

@calgray calgray mentioned this pull request Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants