LIU-368: Add CategoryType support to Palettes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @myxie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -370,6 +384,11 @@ def create_palette_node_from_params(params) -> tuple: | |||
| text = value | |||
| elif key == "description": | |||
| comp_description = value | |||
| elif key == "categorytype": | |||
There was a problem hiding this comment.
suggestion: Consider normalizing key names
To avoid potential issues with inconsistent key names, consider normalizing the key names (e.g., converting them to lowercase) before comparison.
Suggested change
| elif key == "categorytype": | |
| elif key.lower() == "categorytype": |
| @@ -370,6 +384,11 @@ | |||
| text = value | |||
| elif key == "description": | |||
| comp_description = value | |||
| elif key == "categorytype": | |||
| if value not in KNOWN_CATEGORY_TYPES: | |||
There was a problem hiding this comment.
suggestion: Consider case-insensitive comparison for category types
To make the category type comparison more robust, consider performing a case-insensitive comparison. This can be achieved by converting both value and the elements in KNOWN_CATEGORY_TYPES to lowercase before comparison.
Suggested change
| if value not in KNOWN_CATEGORY_TYPES: | |
| if value.lower() not in (category.lower() for category in KNOWN_CATEGORY_TYPES): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📝
Write an overview about it.
Details
Describe more what you did on changes.
Bugfixes 🐛 (delete if dind't have any)
Checks