-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIU-408: Add support for Python 3.11 and 3.12 #290
Conversation
- Add `setuptools` as a dependency: pypa/virtualenv#2487 - Bump pyzmq version number: https://pyzmq.readthedocs.io/en/latest/changelog.html#id11 - Bump pydantic version number: pydantic/pydantic#9637
- This should resolve linter errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that is was so simple!
Reviewer's Guide by SourceryThis PR updates the codebase to support Python 3.11 and 3.12 by making necessary dependency updates and modifying the entry points handling code to accommodate different Python versions. The changes include updating package dependencies, modifying the entry points loading mechanism, and extending CI workflow to test against new Python versions. Sequence diagram for entry points loading mechanismsequenceDiagram
participant Tool as Tool
participant EntryPoints as importlib.metadata.entry_points
participant Sys as sys
Tool->>Sys: Check Python version
alt Python < 3.10
Tool->>EntryPoints: entry_points()
loop For each entry point in dlg.tool_commands
EntryPoints->>Tool: Load and register commands
end
else
Tool->>EntryPoints: entry_points(group="dlg.tool_commands")
loop For each entry point in dlg.tool_commands
EntryPoints->>Tool: Load and register commands
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @myxie - I've reviewed your changes - here's some feedback:
Overall Comments:
- The upgrade to pydantic 2.5+ is a major version change that may introduce breaking changes. Please document any necessary migration steps and confirm compatibility testing has been performed.
- Consider explicitly documenting the full range of supported Python versions in the PR description, including the minimum supported version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR adds support for newer Python version, Python3.11 and 3.12.
As Python 3.8 and older version are no longer being maintained, it is useful to make sure we are working with new-er versions that are more likely to be installed on user's machines and shared computing facilities.
Summary by Sourcery
Add support for Python 3.11 and 3.12 by updating dependencies and CI configurations to ensure compatibility with these versions.
New Features:
Enhancements:
CI: