Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixrule(aria_landmark_name_unique): Change the accessible name length limitation #2096

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fixrule(aria_landmark_name_unique): Change the accessible name length limitation #2096

merged 4 commits into from
Nov 13, 2024

Conversation

shunguoy
Copy link
Contributor

  • Rule bug: aria_landmark_name_unique

This PR is related to the following issue(s):

Testing reference:

  • test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/dcs-example.html
  • After the fix, two violations with the message should be gone
    "Multiple elements with region landmarks within the same parent region are not distinguished from one another because they have the same "configuring authentication data and aliases with authdata a... label"

I have conducted the following for this PR:

  • [ x] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [ x] I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy self-assigned this Nov 13, 2024
@shunguoy shunguoy added the engine Issues in the accessibility-checker-engine component label Nov 13, 2024
@shunguoy shunguoy marked this pull request as ready for review November 13, 2024 18:47
@tombrunet tombrunet merged commit 464d47d into master Nov 13, 2024
17 checks passed
@tombrunet tombrunet deleted the dcs-aria_landmark_name_unique branch November 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees

@shunguoy shunguoy

Labels
engine Issues in the accessibility-checker-engine component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunguoy @tombrunet