This repository has been archived by the owner on Jul 22, 2019. It is now read-only.
Fixes #142: Move indexing logic entirely to the server-side #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indexing is now triggered as part of the onInitialize() request. Any code on the client related to indexing (except registered VS Code commands) is moved to the server. The user commands are just proxies - they make a request to the server. All the code related to building, querying and maintaining the index is moved to the index.ts file. Wherever possible, standard message request from the language server protocol are used instead of custom messages. For example onDidChangeContent() and onDidChangeWatchedFiles() instead of the custom "buildObjectTreeForDocument", "saveTreeCache", etc.
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexing is now triggered as part of the onInitialize() request.
Any code on the client related to indexing (except registered VS Code
commands) is moved to the server. The user commands are just proxies -
they make a request to the server.
All the code related to building, querying and maintaining the index is
moved to the index.ts file.
Wherever possible, standard message request from the language server
protocol are used instead of custom messages. For example
onDidChangeContent() and onDidChangeWatchedFiles() instead of the custom
"buildObjectTreeForDocument", "saveTreeCache", etc.